On 2/25/21 5:10 PM, Tetsuo Handa wrote:

On 2021/02/26 9:00, Shuah Khan wrote:

quoted

This patch makes changes to 3 different drivers. Please split these
patches. Makes it easier to revert or fix them.

Patch1 could add common routines and use them in stud_dev and vudc
Same for usbip_event_lock_killable() and usbip_event_unlock().
Introduce them in a separate patch.

__usbip_sockfd_store() could be made common to stub_dev and vudc
similar to usbip_prepare_threads() and usbip_unprepare_threads()

It will lot easier to review if this large patch is split into
smaller patches.

Then, can we apply
https://lkml.kernel.org/r/20210205135707.4574-1-penguin-kernel@I-love.SAKURA.ne.jp
as the first patch? It is very easy to review and apply and backport to stable.

Same concerns as before about error path handling.

I have a patch in the works that is simpler and solves the crashes
you are seeing and addresses my error path concerns.

I will send it out later on today. Thanks for all the heavy lifting.
Much appreciated.

thanks,
-- Shuah