On 2/20/21 2:51 AM, Tetsuo Handa wrote:

On 2021/02/20 15:58, Greg Kroah-Hartman wrote:

quoted

quoted

quoted

Also please run the usbip test on your changes:
tools/testing/selftests/drivers/usb/usbip/usbip_test.sh

Too much requirements for me to run that test. I'm not a user of your module.

It should be self-contained, what requirements do you see that you do
not have?

It asks me to build usbip tools from source code. I took source code from
https://github.com/lucianm/usbip-utils , but I couldn't rebuild without
removing -Werror from Makefile . Where is maintained source code?
Please embed appropriate URL into usbip_test.sh .

usbip tools are part of the kernel source. Please look under:

tools/usb/usbip

Too many error messages to convince that the test succeeded. The only device listed
in my environment is a Virtual Mouse, which makes me wonder if the test did work.
Therefore, I think I should wait for your test result in your environment which
would list appropriate devices.

Please use the right tool version from the kernel sources. I usually
run with server and client running on the same system, client going
over the loopback interface. Server exports any input devices mouse
or keyboard.

I will run the test on your v3.

thanks,
-- Shuah