Re: [PATCH 2/3] usb: gadget: composite: Split composite reset and disconnect
From: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
Date: 2021-01-08 02:20:38
Also in:
lkml
From: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
Date: 2021-01-08 02:20:38
Also in:
lkml
Hi Wesley, Felipe Balbi wrote:
Hi, Wesley Cheng [off-list ref] writes:quoted
+void composite_reset(struct usb_gadget *gadget) +{ + /* + * Section 1.4.13 Standard Downstream Port of the USB battery charging + * specification v1.2 states that a device connected on a SDP shall only + * draw at max 100mA while in a connected, but unconfigured state.The requirements are different, though. I think OTG spec has some extra requirements where only 8mA can be drawn max. You need to check for the otg flag. Moreover, USB3+ spec has units of 150mA meaning the device can't draw 100mA (IIRC).
We see issue with this patch series. For our device running at SSP, the device couldn't recover from a port reset and remained in eSS.Inactive state. This patch series is already in Greg's usb-testing. Please review and help fix it. We can see the failure once the patch "usb: gadget: configfs: Add a specific configFS reset callback" is introduced. Thanks, Thinh