Re: [PATCH -next] um: virt-pci: Fix the application of sizeof to pointer
From: Johannes Berg <johannes@sipsolutions.net>
Date: 2021-09-03 08:20:45
Also in:
lkml
From: Johannes Berg <johannes@sipsolutions.net>
Date: 2021-09-03 08:20:45
Also in:
lkml
On Fri, 2021-09-03 at 15:51 +0800, Yang Li wrote:
sizeof() when applied to a pointer typed expression gives the size of the pointer. Clean up coccicheck warning: ./arch/um/drivers/virt-pci.c:192:20-26: ERROR: application of sizeof to pointer
- memset(data, 0xff, sizeof(data)); + memset(data, 0xff, sizeof(*data));
Oops. I guess I only tested on 64-bit where this is the same, and in fact on 32-bit it also wouldn't matter since you can't even do 64-bit reads there :) A Fixes: tag would be nice, but otherwise Reviewed-by: Johannes Berg <johannes@sipsolutions.net> johannes _______________________________________________ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um