Re: [uml-devel] UML/man: BLKGETSIZE takes a long, not an int
From: Michael Kerrisk <hidden>
Date: 2007-08-27 13:27:59
Also in:
lkml
Hello Nicolas,
I fear that my bug-report yesterday was very badly written, with me writing to the wrong mailing-list and all. I was saying:quoted
I found a type mismatch in UML that makes host block devices unusable as ubd devices on x86_64 and other 64 bits systems (segfault of the mm subsystem): In block/ioctl.c, the following lines show that the BLKGETSIZE ioctl expects a pointer to a long: case BLKGETSIZE: if ((bdev->bd_inode->i_size >> 9) > ~0UL) return -EFBIG; return put_ulong(arg, bdev->bd_inode->i_size >> 9); In arch/um/os-Linux/file.c, os_file_size calls it with an int. The ioctl_list man page should be fixed as well.
manual page changed for 2.65:
--- ioctl_list.2
+++ ioctl_list.2 (working copy)@@ -243,7 +243,7 @@ 0x0000125D BLKROSET const int * 0x0000125E BLKROGET int * 0x0000125F BLKRRPART void -0x00001260 BLKGETSIZE int * +0x00001260 BLKGETSIZE unsigned long * 0x00001261 BLKFLSBUF void 0x00001262 BLKRASET int 0x00001263 BLKRAGET int *
Thanks, Michael -- Michael Kerrisk maintainer of Linux man pages Sections 2, 3, 4, 5, and 7 Want to help with man page maintenance? Grab the latest tarball at http://www.kernel.org/pub/linux/docs/manpages/ read the HOWTOHELP file and grep the source files for 'FIXME'. ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ User-mode-linux-devel mailing list User-mode-linux-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel