Re: [PATCH 12/12] tracing/probes: Propagate error codes in eprobe and fprobe creation

From
sashiko-bot@kernel.org
Date
2026-11-09 00:46:06
Reply to
Masami Hiramatsu (Google), 2026-11-09
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] tracing/probes: missing Fixes trailers for overwritten error
  codes
--

commit 435aff670b6c20ffbcde000e1c0b092b53b663a8
Author: Masami Hiramatsu (Google) [off-list ref]
tracing/probes: Propagate error codes in eprobe and fprobe creation

In __trace_eprobe_create() and trace_fprobe_create_internal(), error
codes returned by helper and registration functions (such as -ENOMEM or
-EEXIST) are overwritten with -EINVAL.

Propagate the actual error codes to the caller.

Signed-off-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
[Severity: Low]
Since this fixes overwritten error codes in __trace_eprobe_create() and
trace_fprobe_create_internal(), should it include the following Fixes:
tags?

  Fixes: 752be5c5c910 ("tracing/eprobe: Add eprobe filter support")
  Fixes: 08c9306fc2e3 ("tracing/fprobe-event: Assume fprobe is a return event by $retval")
  Fixes: 8275637215bd ("tracing: Adopt __free() and guard() for trace_fprobe.c")

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/179418408457.227715.1485179201014819821.stgit@devnote2?part=12
Thread (20 messages) 20 messages, 2 authors, last reply 4d ago
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help