Re: [PATCH 08/12] tracing/probes: Reject array count on non-dereference string sources

From
sashiko-bot@kernel.org
Date
2026-11-09 00:41:41
Reply to
Masami Hiramatsu (Google), 2026-11-09
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] tracing/probes: missing Fixes trailer for string array support
  commit
--

commit 78c886d046541847b05a6f45643e9267eae178e0
Author: Masami Hiramatsu (Google) [off-list ref]
tracing/probes: Reject array count on non-dereference string sources

The runtime array loop (FETCH_OP_LP_ARRAY) for string types requires a
preceding memory dereference instruction so it can advance the pointer
address on each iteration. Non-dereference string sources such as $comm,
immediate strings, and eprobe event fields cannot be indexed as pointer
arrays, but finalize_fetch_insn() still accepts an array count on them
and emits an invalid FETCH_OP_LP_ARRAY sequence.

Reject string array counts when the preceding operation is not a memory
dereference.

Signed-off-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
[Severity: Low]
This looks like a bug fix for string array support.  Should this include:

  Fixes: 40b53b771806 ("tracing: probeevent: Add array type support")

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/179418408457.227715.1485179201014819821.stgit@devnote2?part=8
Thread (20 messages) 20 messages, 2 authors, last reply 4d ago
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help