[PATCH v2 03/15] rv: Refactor da_trace() functions to get strings internally
flat view
HOTtoday
From: Gabriele Monaco <gmonaco@redhat.com>
Date: 2026-10-01 15:21:41
Also in:
bpf, lkml
Subsystem:
runtime verification (rv), the rest · Maintainers:
Steven Rostedt, Gabriele Monaco, Linus Torvalds
Revision v2 of 2 in this series.
Revisions (2)
- rfc [diff vs current]
- v2 current
The da_trace_event() and da_trace_error() functions are currently called with strings and the callers are converting the state/event enums to the corresponding string representation. This is unnecessary and is problematic if an alternative implementation is needed (e.g. BPF without using strings). Change the functions to accept enums and pass the string representations to the tracepoints only internally. Signed-off-by: Gabriele Monaco <gmonaco@redhat.com> --- include/rv/da_monitor.h | 40 ++++++++++++++++++++++------------------ 1 file changed, 22 insertions(+), 18 deletions(-)
diff --git a/include/rv/da_monitor.h b/include/rv/da_monitor.h
index 6fc5ef8142ac..7f0bdfd7cce3 100644
--- a/include/rv/da_monitor.h
+++ b/include/rv/da_monitor.h@@ -633,19 +633,22 @@ static inline void da_monitor_destroy(void) */ static inline void da_trace_event(struct da_monitor *da_mon, - char *curr_state, char *event, - char *next_state, bool is_final, + enum states curr_state, enum events event, + enum states next_state, da_id_type id) { - CONCATENATE(trace_event_, MONITOR_NAME)(curr_state, event, next_state, - is_final); + CONCATENATE(trace_event_, MONITOR_NAME)(model_get_state_name(curr_state), + model_get_event_name(event), + model_get_state_name(next_state), + model_is_final_state(next_state)); } static inline void da_trace_error(struct da_monitor *da_mon, - char *curr_state, char *event, + enum states curr_state, enum events event, da_id_type id) { - CONCATENATE(trace_error_, MONITOR_NAME)(curr_state, event); + CONCATENATE(trace_error_, MONITOR_NAME)(model_get_state_name(curr_state), + model_get_event_name(event)); } /*
@@ -662,19 +665,24 @@ static inline da_id_type da_get_id(struct da_monitor *da_mon) */ static inline void da_trace_event(struct da_monitor *da_mon, - char *curr_state, char *event, - char *next_state, bool is_final, + enum states curr_state, enum events event, + enum states next_state, da_id_type id) { - CONCATENATE(trace_event_, MONITOR_NAME)(id, curr_state, event, - next_state, is_final); + CONCATENATE(trace_event_, MONITOR_NAME)(id, + model_get_state_name(curr_state), + model_get_event_name(event), + model_get_state_name(next_state), + model_is_final_state(next_state)); } static inline void da_trace_error(struct da_monitor *da_mon, - char *curr_state, char *event, + enum states curr_state, enum events event, da_id_type id) { - CONCATENATE(trace_error_, MONITOR_NAME)(id, curr_state, event); + CONCATENATE(trace_error_, MONITOR_NAME)(id, + model_get_state_name(curr_state), + model_get_event_name(event)); } #endif /* RV_MON_TYPE */
@@ -695,17 +703,13 @@ static inline bool da_event(struct da_monitor *da_mon, enum events event, da_id_ next_state = model_get_next_state(curr_state, event); if (next_state == INVALID_STATE) { react(curr_state, event); - da_trace_error(da_mon, model_get_state_name(curr_state), - model_get_event_name(event), id); + da_trace_error(da_mon, curr_state, event, id); return false; } if (likely(try_cmpxchg(&da_mon->curr_state, &curr_state, next_state))) { if (!da_monitor_event_hook(da_mon, curr_state, event, next_state, id)) return false; - da_trace_event(da_mon, model_get_state_name(curr_state), - model_get_event_name(event), - model_get_state_name(next_state), - model_is_final_state(next_state), id); + da_trace_event(da_mon, curr_state, event, next_state, id); return true; } }
--
2.55.0