Re: [PATCH v2 05/15] tools/rv: Move argument parsing from in_kernel to utils
flat view
From: bot+bpf-ci@kernel.org
Date: 2026-10-02 00:25:27
Also in:
bpf, lkml
tools/rv: Move argument parsing from in_kernel to utils
TL;DR: Nit only: the shared parse_arguments() in utils.c still prints an "ikm:" prefix in its debug message, which would mislabel -v output for BPF monitors later in the series. Cosmetic, no behaviour change.
quoted hunk ↗ jump to hunk
diff --git a/tools/verification/rv/src/utils.c b/tools/verification/rv/src/utils.c index 5677b439dc2f..e19dd65ec789 100644 --- a/tools/verification/rv/src/utils.c +++ b/tools/verification/rv/src/utils.c
[ ... ]
quoted hunk ↗ jump to hunk
@@ -45,3 +48,91 @@ void debug_msg(const char *fmt, ...)
[ ... ]
quoted hunk ↗ jump to hunk
+ } + } + + debug_msg("ikm: my pid is %d\n", config.my_pid);
Is the "ikm: " prefix still appropriate in this debug message now that
parse_arguments() lives in the shared utils.c?
At this commit only ikm_run_monitor() calls parse_arguments(), so the output
is correct. Later in the series, 46210ac84ea4 ("tools/rv: Implement BPF
monitor loading and tracing") adds bpf_run_monitor(), which sets
config.is_bpf = true and then calls parse_arguments(monitor_name, argc,
argv).
With that, running "rv mon <bpf_monitor> -v" prints "ikm: my pid is N",
even though bpf_run_monitor() labels its own messages with "bpf:" (for
example "bpf: failed parsing arguments"). The message is still unchanged
at the series tip, 3b00bc9b2e54.
Would dropping the "ikm: " prefix from the shared helper work? The selftest
in tests/rv_mon.t only matches "my pid is $pid", so it should keep passing.
This is cosmetic, it only mislabels the -v output and does not change
behaviour.
---
AI reviewed your patch. Please fix the bug or email reply why it's not a bug.
See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md
CI run summary: https://github.com/kernel-patches/bpf/actions/runs/36944413541