Re: [PATCH v15 05/12] tracing/wprobe: Add wprobe (watchpoint probe) trace event support
From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Date: 2026-09-14 05:25:15
Also in:
linux-perf-users, sashiko-reviews
On Mon, 07 Sep 2026 04:15:03 +0000 sashiko-bot@kernel.org wrote:
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] The `readme_msg` in `trace.c` instructs users to write to `wprobe_events`, but this file is never created. -- commit 5c44f59e0b2737617a0b5934e625357ecffcc63d Author: Masami Hiramatsu (Google) [off-list ref] tracing/wprobe: Add wprobe (watchpoint probe) trace event support This commit introduces hardware-breakpoint-based dynamic trace event support (wprobe). It creates dynamic events on data read/write accesses using hardware breakpoints and logs the access context and fetchargs. Link: https://lore.kernel.org/all/59637b96946653393a7ad3c7de094094796b39c2.1785067572.git.wangjinchao600@gmail.com/ (local)quoted
diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c index a946e0183fd1e..40c3e1543f6e3 100644 --- a/kernel/trace/trace.c +++ b/kernel/trace/trace.c@@ -4294,8 +4294,12 @@ static const char readme_msg[] = " uprobe_events\t\t- Create/append/remove/show the userspace dynamic events\n" "\t\t\t Write into this file to define/undefine new trace events.\n" #endif +#ifdef CONFIG_WPROBE_EVENTS + " wprobe_events\t\t- Create/append/remove/show the hardware breakpoint dynamic events\n" + "\t\t\t Write into this file to define/undefine new trace events.\n"[Severity: Low] Does this advertise a non-existent interface file to the user? The readme_msg instructs users to write to wprobe_events, but it appears this file is never created by this patch.
Ah, indeed. this is for dynamic_events interface. Thanks,
quoted
+#endif #if defined(CONFIG_KPROBE_EVENTS) || defined(CONFIG_UPROBE_EVENTS) || \ - defined(CONFIG_FPROBE_EVENTS) + defined(CONFIG_FPROBE_EVENTS) || defined(CONFIG_WPROBE_EVENTS) "\t accepts: event-definitions (one definition per line)\n"-- Sashiko AI review · https://sashiko.dev/#/patchset/178875277830.93794.14247844688761142429.stgit@devnote2?part=5
-- Masami Hiramatsu (Google) [off-list ref]