Thread (47 messages) 47 messages, 4 authors, 1d ago

Re: [PATCH v3 16/17] selftests/verification: Rearrange the wwnr_printk test

From: Gabriele Monaco <gmonaco@redhat.com>
Date: 2026-07-10 08:41:34
Also in: linux-kselftest, lkml

On Fri, 2026-07-10 at 08:18 +0200, Nam Cao wrote:
Gabriele Monaco [off-list ref] writes:
quoted
Simplify the test and run the steps expecting no reaction before the one
expecting reactions.
This requirement is not clear from the code. I fear a new developer who
wants to introduce a new test case will easily trip over this, or even
us a few months from now.

Instead of this, how about each test case discards or ignores all
previous reactions?
Fair points, the issue is that we are hammering wwnr, on some systems we may
still see printks for long after the monitor was disabled, I tried that grep -m1
trick to mitigate that.

To ignore all previous reactions reliably we need to wait for the buffers to
flush, something like waiting for a full second for nothing new on the
ringbuffer perhaps. I could think of that or at least make this more clear with
comments.

Thanks,
Gabriele
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help