Thread (47 messages) 47 messages, 4 authors, 3d ago

Re: [PATCH v3 14/17] verification/rvgen: Add selftests for rvgen kunit

From: Gabriele Monaco <gmonaco@redhat.com>
Date: 2026-07-09 15:52:26
Also in: lkml

On Thu, 2026-07-09 at 10:11 +0200, Nam Cao wrote:
Gabriele Monaco [off-list ref] writes:
quoted
The rvgen kunit command patches monitor files and adds necessary
definitions for kunit tests.

Add a test case validating its behaviour on dummy generated files and
comparing it against reference files, like it's done for rvgen monitor.

Signed-off-by: Gabriele Monaco <gmonaco@redhat.com>
I am not entirely sure about this. In the future, when the generation
output is changed, all the references files also need to be updated. So
it's not clear to me if this really saves future development effort.
Yeah that's an issue with all this testing with golden files. At least unless we
change the output drastically, changes to those should be easy to apply and to
review (and LLMs can help here too).
But well, we will see. For now:

Reviewed-by: Nam Cao <redacted>
Thanks,
Gabriele
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help