Thread (7 messages) 7 messages, 2 authors, 10d ago

Re: [PATCH 1/3] tracing/user_events: Simplify data output in user_seq_show()

From: Markus Elfring <hidden>
Date: 2026-06-09 16:44:22
Also in: kernel-janitors, lkml

quoted
@@ -2800,8 +2800,7 @@ static int user_seq_show(struct seq_file *m, void *p)
 
 	mutex_unlock(&group->reg_mutex);
 
-	seq_puts(m, "\n");
-	seq_printf(m, "Active: %d\n", active);
+	seq_printf(m, "\nActive: %d\n", active);
 	seq_printf(m, "Busy: %d\n", busy);
This isn't a critical section and I find the original way easier to read.
Would you prefer to use a seq_putc() call instead at such a source code place?
https://elixir.bootlin.com/linux/v7.1-rc7/source/kernel/trace/trace_events_user.c#L2803

But the other two patches are fine.
Thanks for another bit of positive feedback.

Regards,
Markus
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help