Re: [PATCH net-next v2 07/10] devlink: allow devlink instance allocation without a backing device

From
Jiri Pirko <jiri@resnulli.us>
Date
2026-03-02 13:15:40
Also in
linux-doc, linux-rdma, netdev
Reply to
Jakub Kicinski, 2026-02-28
Sun, Mar 01, 2026 at 12:01:38AM +0100, kuba@kernel.org wrote:
On Wed, 25 Feb 2026 14:34:19 +0100 Jiri Pirko wrote:
quoted
-	dev_warn(port->devlink->dev, "Type was not set for devlink port.");
+	if (port->devlink->dev)
+		dev_warn(port->devlink->dev,
+			 "Type was not set for devlink port.");
since I'm already nit-picking - maybe we should have a helper for this
case an pr_warn() the message if dev is NULL?
Okay
Thread (21 messages) 21 messages, 2 authors, last reply 2026-03-02
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help