Re: [PATCH net-next v2 07/10] devlink: allow devlink instance allocation without a backing device

From
Jakub Kicinski <kuba@kernel.org>
Date
2026-02-28 23:01:40
Also in
linux-doc, linux-rdma, netdev
Reply to
Jiri Pirko, 2026-02-25
On Wed, 25 Feb 2026 14:34:19 +0100 Jiri Pirko wrote:
quoted hunk ↗ jump to hunk
-	dev_warn(port->devlink->dev, "Type was not set for devlink port.");
+	if (port->devlink->dev)
+		dev_warn(port->devlink->dev,
+			 "Type was not set for devlink port.");
since I'm already nit-picking - maybe we should have a helper for this
case an pr_warn() the message if dev is NULL?
Thread (21 messages) 21 messages, 2 authors, last reply 2026-03-02
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help