Re: [PATCH v7 2/2] ring-buffer: Skip invalid sub-buffers when validating persistent ring buffer

From
Steven Rostedt <rostedt@goodmis.org>
Date
2026-03-09 02:19:23
Also in
lkml
Reply to
Masami Hiramatsu (Google), 2026-03-09
On Mon, 9 Mar 2026 09:53:07 +0900
Masami Hiramatsu (Google) [off-list ref] wrote:
quoted
quoted
I just realized that the origin didn't have correct grammar. But we
still check the subbufs, why remove that comment?

The original should have said:

	/* Do the meta buffers and subbufs have correct data? */  
I just removed the data check from this loop, so I think this should
focus on checking metadata itself. The data is checked later.  
Other checks in the loop are;

- the entries in meta::buffers[] are inside correct range.
- the duplicated entries in the meta::buffers[].

So this only checks the meta::buffers[] (index array) now.

/*
 * Ensure the meta::buffers have correct data. The data in each subbufs are
 * checked later in rb_meta_validate_events().
 */

This will be more clear.
Sure.

-- Steve
Thread (10 messages) 10 messages, 2 authors, last reply 2026-03-09
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help