Re: [RFC PATCH 1/2] locking: add mutex_lock_nospin()

From
Yafang Shao <hidden>
Date
2026-03-06 02:22:48
Also in
bpf, lkml
Reply to
Steven Rostedt, 2026-03-05
On Thu, Mar 5, 2026 at 9:20 PM Steven Rostedt [off-list ref] wrote:
On Thu, 5 Mar 2026 13:40:27 +0800
Yafang Shao [off-list ref] wrote:
quoted
Exactly. ftrace is intended for debugging and should not significantly
impact real workloads. Therefore, it's reasonable to make it sleep if
it cannot acquire the lock immediately, rather than spinning and
consuming CPU cycles.
Actually, ftrace is more than just debugging. It is the infrastructure for
live kernel patching as well.
good to know.
quoted
quoted
BTW, you should expand the commit log of patch 1 to include the
rationale of why we should add this feature to mutex as the information
in the cover letter won't get included in the git log if this patch
series is merged. You should also elaborate in comment on under what
conditions should this this new mutex API be used.
Sure.  I will update it.

BTW, these issues are notably hard to find. I suspect there are other
locks out there with the same problem.
As I mentioned, I'm not against the change. I just want to make sure the
rationale is strong enough to make the change.

One thing that should be modified with your patch is the name. "nospin"
references the implementation of the mutex. Instead it should be called
something like: "noncritical" or "slowpath" stating that the grabbing of
this mutex is not of a critical section.

Maybe an entirely new interface should be defined:


struct slow_mutex;
Is it necessary to define a new structure for this slow mutex? We
could simply reuse the existing struct mutex instead. Alternatively,
should we add some new flags to this slow_mutex for debugging
purposes?
slow_mutex_lock()
slow_mutex_unlock()
These two APIs appear sufficient to handle this use case.
etc,

that makes it obvious that this mutex may be held for long periods of time.
In fact, this would be useful for RT workloads, as these mutexes could be
flagged to warn RT critical tasks if those tasks were to take one of them.

There has been some talk to mark paths in the kernel that RT tasks would
get a SIGKILL if they were to hit a path that is known to be non
deterministic.
Thanks for your information.

-- 
Regards
Yafang
Thread (29 messages) 29 messages, 5 authors, last reply 2026-03-09
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help