On Wed, Mar 4, 2026 at 6:11 PM Peter Zijlstra [off-list ref] wrote:
On Wed, Mar 04, 2026 at 05:37:31PM +0800, Yafang Shao wrote:
quoted
On Wed, Mar 4, 2026 at 5:03 PM Peter Zijlstra [off-list ref] wrote:
quoted
On Wed, Mar 04, 2026 at 03:46:49PM +0800, Yafang Shao wrote:
quoted
Introduce mutex_lock_nospin(), a helper that disables optimistic spinning
on the owner for specific heavy locks. This prevents long spinning times
that can lead to latency spikes for other tasks on the same runqueue.
This makes no sense; spinning stops on need_resched().
Hello Peter,
The condition to stop spinning on need_resched() relies on the mutex
owner remaining unchanged. However, when multiple tasks contend for
the same lock, the owner can change frequently. This creates a
potential TOCTOU (Time of Check to Time of Use) issue.
mutex_optimistic_spin
owner = __mutex_trylock_or_owner(lock);
mutex_spin_on_owner
// the __mutex_owner(lock) might get a new owner.
while (__mutex_owner(lock) == owner)
How do these new owners become the owner? Are they succeeding the
__mutex_trylock() that sits before mutex_optimistic_spin() and
effectively starving the spinner?
Something like the below would make a difference if that were so.
The following change made no difference; concurrent runs still result
in prolonged system time.
real 0m5.265s user 0m0.000s sys 0m4.921s
real 0m5.295s user 0m0.002s sys 0m4.697s
real 0m5.293s user 0m0.003s sys 0m4.844s
real 0m5.303s user 0m0.001s sys 0m4.511s
real 0m5.303s user 0m0.000s sys 0m4.694s
real 0m5.302s user 0m0.002s sys 0m4.677s
real 0m5.313s user 0m0.000s sys 0m4.837s
real 0m5.327s user 0m0.000s sys 0m4.808s
real 0m5.330s user 0m0.001s sys 0m4.893s
real 0m5.358s user 0m0.005s sys 0m4.919s
Our kernel is not built with CONFIG_PREEMPT enabled, so prolonged
system time can lead to CPU pressure and potential latency spikes.
Since we can reliably reproduce this unnecessary spinning, why not
improve it to reduce the overhead?
--
Regards
Yafang