Thread (36 messages) 36 messages, 9 authors, 2025-12-03

Re: [PATCH 3/3] tracing: move tracing declarations from kernel.h to a dedicated header

From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: 2025-12-01 02:50:50
Also in: dri-devel, intel-gfx, linux-modules, lkml

On Sun, Nov 30, 2025 at 11:09:25PM +0000, david laight wrote:
On Sun, 30 Nov 2025 21:44:46 +0200
Andy Shevchenko [off-list ref] wrote:
...
It is worth checking whether the files get included anyway, and whether it
really makes that much difference.

Fiddling with kernel.h and extracting small 'leaf' headers from it is also
unlikely to make a big difference.
It makes a big difference for the kernel.h and its (ab)users.
Especially when we have cyclic dependencies and "include everything"
cases due to other _headers_ including kernel.h.
Try adding a syntax error to (say) sys/ioctl.h and see where it is included
from the first time - I suspect you'll be surprised.
Working on that include list might be more fruitful (in reducing build times).
kernel.h elimination (in the form it exists right now) is very fruitful.
However, you may help with the (say) ioctl.h or whatever you consider
really fruitful, we all will thank you (no jokes).

-- 
With Best Regards,
Andy Shevchenko

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help