Re: [PATCH 2/3] kernel.h: move VERIFY_OCTAL_PERMISSIONS() to sysfs.h
From: Yury Norov <yury.norov@gmail.com>
Date: 2025-11-30 17:56:07
Also in:
dri-devel, intel-gfx, linux-modules, lkml
Subsystem:
documentation, the rest · Maintainers:
Jonathan Corbet, Linus Torvalds
On Sat, Nov 29, 2025 at 10:35:54PM +0200, Andy Shevchenko wrote:
On Sat, Nov 29, 2025 at 10:34:02PM +0200, Andy Shevchenko wrote:quoted
On Sat, Nov 29, 2025 at 10:24:55PM +0200, Andy Shevchenko wrote:quoted
On Sat, Nov 29, 2025 at 02:53:01PM -0500, Yury Norov (NVIDIA) wrote:quoted
The macro is related to sysfs, but is defined in kernel.h. Move it to the proper header, and unload the generic kernel.h.Tough guy :-) I hope it builds well in your case. FWIW, https://lore.kernel.org/lkml/20220603172101.49950-1-andriy.shevchenko@linux.intel.com/ (local) https://lore.kernel.org/lkml/20240212115500.2078463-1-max.kellermann@ionos.com/ (local) https://lore.kernel.org/lkml/20240215093646.3265823-1-max.kellermann@ionos.com/ (local) Assuming it builds in allmodconfig, allyesconfig on x86_32/64 and arm/64 Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>Actually, one thing should be fixed, i.e. Documentation/filesystems/sysfs.rst:123:Note as stated in include/linux/kernel.h "OTHER_WRITABLE? ...And just in case, look into https://lore.kernel.org/r/20251126214709.2322314-1-andriy.shevchenko@linux.intel.com (local)
Sure. Please find attached. From 8b08bfd1d4b885bffb67c548d17d98760ca06e76 Mon Sep 17 00:00:00 2001 From: "Yury Norov (NVIDIA)" <yury.norov@gmail.com> Date: Sun, 30 Nov 2025 12:50:11 -0500 Subject: [PATCH] sysfs: Align update documentation This series moves VERIFY_OCTAL_PERMISSIONS() from linux/kernel.h to linux/sysfs.h. Update documentation accordingly Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Signed-off-by: Yury Norov (NVIDIA) <yury.norov@gmail.com> --- Documentation/filesystems/sysfs.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/filesystems/sysfs.rst b/Documentation/filesystems/sysfs.rst
index 2703c04af7d0..ffcef4d6bc8d 100644
--- a/Documentation/filesystems/sysfs.rst
+++ b/Documentation/filesystems/sysfs.rst@@ -120,7 +120,7 @@ is equivalent to doing:: .store = store_foo, }; -Note as stated in include/linux/kernel.h "OTHER_WRITABLE? Generally +Note as stated in include/linux/sysfs.h "OTHER_WRITABLE? Generally considered a bad idea." so trying to set a sysfs file writable for everyone will fail reverting to RO mode for "Others".
--
2.43.0