Re: [PATCH v11 08/15] unwind_user/sframe: Wire up unwind_user to sframe
From: Steven Rostedt <rostedt@goodmis.org>
Date: 2025-10-24 19:00:35
Also in:
bpf, linux-mm, lkml
From: Steven Rostedt <rostedt@goodmis.org>
Date: 2025-10-24 19:00:35
Also in:
bpf, linux-mm, lkml
On Fri, 24 Oct 2025 16:29:07 +0200 Jens Remus [off-list ref] wrote:
@Steven: Any idea why you added pt_regs? Your v9 even had this other
instance of unused pt_regs:
+static struct unwind_user_frame *get_fp_frame(struct pt_regs *regs)
+{
+ return &fp_frame;
+}According to the history: https://lore.kernel.org/linux-trace-kernel/20250717012848.927473176@kernel.org/ (local) Which has: Changes since v8: https://lore.kernel.org/linux-trace-kernel/20250708021115.894007410@kernel.org/ (local) - Rebased on the changes by Mathieu in the kernel/unwind/user.c file https://lore.kernel.org/all/20250710164301.3094-2-mathieu.desnoyers@efficios.com/ (local) It looks like it came in from Mathieu's updates, which was trying to deal with compat. But then after noticing that compat wasn't working on my tests boxes, I removed it. The removal failed to notice that regs is now unused. -- Steve