Re: [PATCH v2 1/2] unwind_user/x86: Enable frame pointer unwinding on x86

On Tue, 23 Sep 2025 12:51:30 +0200
Peter Zijlstra [off-list ref] wrote:

Moo, and now you have me look at unwind/user.c:

        /* Make sure that the address is word aligned */
        shift = sizeof(long) == 4 ? 2 : 3;
        if (cfa & ((1 << shift) - 1))
                return -EINVAL;

Isn't that just:

	if (cfa & (sizeof(long) - 1))

?

Let me go add a patch to clean that up...

Sure, as long as it's commented.

Thanks,

-- Steve