Re: [PATCH v2 2/2] unwind deferred/x86: Do not defer stack tracing for compat tasks

From
Steven Rostedt <rostedt@kernel.org>
Date
2025-09-23 12:16:43
Also in
lkml
Reply to
Peter Zijlstra, 2025-09-23
On Tue, 23 Sep 2025 12:45:15 +0200
Peter Zijlstra [off-list ref] wrote:
Changelog seems to forget mentioning *why* we can't unwind compat.

I'm sure I've seen compat FP unwind support at some point in this
series. Did that go missing somewhere?

Also, these two patches are in the wrong order, first you enable things,
including compat tasks, and then you go 'whoopsie, no compats'.
Sure, we can swap it. Yes, we had patches to support it, but they
were a bit complicated and when I tested them, they didn't work. But
then I also noticed that the current stack tracing didn't work on
compat either. Instead of adding complicated code that wasn't working
on my machine, I decided to remove the patches. But after I did that, I
realized I needed to make sure it wasn't even tried, which is this
patch.

I'm not sure who needs profiling on compat code, and I figured we can
not add the new deferred work to it if it's not needed. If in the
future we need it, we can add it then.

-- Steve
Thread (8 messages) 8 messages, 2 authors, last reply 2025-09-23
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help