On Mon, Sep 15, 2025 at 12:37:28PM +0200, David Hildenbrand wrote:

On 15.09.25 12:32, Lorenzo Stoakes wrote:

quoted

On Mon, Sep 15, 2025 at 12:25:54PM +0200, David Hildenbrand wrote:

quoted

quoted

quoted

I would just say "The kernel might decide to use a more conservative approach
when collapsing smaller THPs" etc.


Thoughts?

Well I've sort of reviewed oppositely there :) well at least that it needs to be
a hell of a lot clearer (I find that comment really compressed and I just don't
really understand it).

Right. I think these are just details we should hide from the user. And in
particular, not over-document it so we can more easily change semantics
later.

And when we change semantics we can't change comments?

I mean maybe we're talking across purposes here, I'm talking about code
comments, not the documentation.

I agree the documentation should not mention any of this.

Yes, I was talking about patch #15 ("It's just when it comes to documenting
all that stuff in patch #15").

Comments we can adjust as we please of course :)

Yeah, ok this was just a misunderstanding then! :) We are in agreement.

--
Cheers

David / dhildenb

Cheers, Lorenzo