Re: [PATCH v10 03/14] unwind_user: Add compat mode frame pointer support
From: Steven Rostedt <rostedt@goodmis.org>
Date: 2025-06-18 18:37:25
Also in:
bpf, lkml
From: Steven Rostedt <rostedt@goodmis.org>
Date: 2025-06-18 18:37:25
Also in:
bpf, lkml
On Wed, 18 Jun 2025 10:52:22 -0700 Linus Torvalds [off-list ref] wrote:
In this case, I have to agree with PeterZ that this just looks odd: - if (get_user(ra, (unsigned long *)(cfa + frame->ra_off))) + if (UNWIND_GET_USER_LONG(ra, cfa + frame->ra_off, state)) why is UNWIND_GET_USER_LONG() so loud when it just replaces "get_user()"? Note that "get_user()" itself is a macro, and is lower-case, even though you couldn't actually do it as a function (because it changes its first argument in place).
OK, I'll make it lower case. Thanks! -- Steve