Re: [RFC PATCH v2 06/12] sched: Adapt sched tracepoints for RV task model

On Mon, May 19, 2025 at 10:41:47AM +0200, Gabriele Monaco wrote:

On Mon, 2025-05-19 at 10:29 +0200, Nam Cao wrote:

quoted

On Wed, May 14, 2025 at 10:43:08AM +0200, Gabriele Monaco wrote:

quoted

 DECLARE_TRACE_CONDITION(sched_set_state_tp,
-	TP_PROTO(struct task_struct *tsk, int state),
-	TP_ARGS(tsk, state),
+	TP_PROTO(struct task_struct *tsk, int state, bool
from_signal),
+	TP_ARGS(tsk, state, from_signal),
 	TP_CONDITION(!!(tsk->__state) != !!state));

Doesn't this break the build? Because the monitors still use the old
signatures?

I understand you adapt the monitor to this new signature in a follow-
up
patch. But every commits in the series should be buildable, otherwise
you
break "git bisect".

Yeah good point, do you suggest at least fixing signatures in monitors
inside this commit?

Yes.

I can keep the other commits to actually fix/adapt monitors but at
least allow building from here.

 Also yes, I would only change the signature in this commit.

Best regards,
Nam