Thread (4 messages) flat view 4 messages, 2 authors, 2025-05-19

Re: [RFC PATCH v2 06/12] sched: Adapt sched tracepoints for RV task model

From: Nam Cao <hidden>
Date: 2025-05-19 08:29:11
Also in: lkml

On Wed, May 14, 2025 at 10:43:08AM +0200, Gabriele Monaco wrote:
 DECLARE_TRACE_CONDITION(sched_set_state_tp,
-	TP_PROTO(struct task_struct *tsk, int state),
-	TP_ARGS(tsk, state),
+	TP_PROTO(struct task_struct *tsk, int state, bool from_signal),
+	TP_ARGS(tsk, state, from_signal),
 	TP_CONDITION(!!(tsk->__state) != !!state));
Doesn't this break the build? Because the monitors still use the old
signatures?

I understand you adapt the monitor to this new signature in a follow-up
patch. But every commits in the series should be buildable, otherwise you
break "git bisect".

Best regards,
Nam
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help