Re: [PATCH v2 2/4] relayfs: introduce dump of relayfs statistics function

On Fri, May 16, 2025 at 1:06 PM Christoph Hellwig [off-list ref] wrote:

On Fri, May 16, 2025 at 01:02:59PM +0800, Jason Xing wrote:

quoted

Do you mean make it inline in include/linux/relay.h like how
relay_write() works?

Will do that.

Just drop the extern, which is not needed:

size_t relay_dump(struct rchan *chan, int flags);

Got it.

quoted

quoted

This export seems unused even with the entire series applied.

My initial thought was to provide a symbol for some kernel modules to use.

The only user is blktrace, which can't be modular.  Or you plan to
submit a modular user soon, like in the next merge window/  If so
note that and add a pointer to it in the cover letter.

I'm still thinking about how to upstream my internal module... So in
this series, I will remove it.

Thanks,
Jason