Thread (17 messages) flat view 17 messages, 4 authors, 2025-05-16

Re: [PATCH v2 2/4] relayfs: introduce dump of relayfs statistics function

From: Jason Xing <hidden>
Date: 2025-05-16 05:03:36
Also in: linux-block, lkml

On Fri, May 16, 2025 at 12:37 PM Christoph Hellwig [off-list ref] wrote:
On Thu, May 15, 2025 at 02:16:41PM +0800, Jason Xing wrote:
quoted
+extern size_t relay_dump(struct rchan *chan, int flags);
Please don't add pointless externs for function prototypes.
Do you mean make it inline in include/linux/relay.h like how
relay_write() works?

Will do that.
quoted
+EXPORT_SYMBOL_GPL(relay_dump);
This export seems unused even with the entire series applied.
My initial thought was to provide a symbol for some kernel modules to use.

Thanks,
Jason
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help