Re: [RFC PATCH V3 25/43] rv64ilp32_abi: exec: Adapt 64lp64 env and argv
From: Guo Ren <guoren@kernel.org>
Date: 2025-03-26 09:22:57
Also in:
bpf, kvm, kvm-riscv, linux-arch, linux-btrfs, linux-crypto, linux-fsdevel, linux-input, linux-media, linux-mm, linux-nfs, linux-perf-users, linux-riscv, linux-sctp, linux-serial, linux-usb, lkml, netdev, netfilter-devel
On Wed, Mar 26, 2025 at 1:19 AM Sergey Shtylyov [off-list ref] wrote:
On 3/25/25 3:16 PM, guoren@kernel.org wrote:quoted
From: "Guo Ren (Alibaba DAMO Academy)" <guoren@kernel.org> The rv64ilp32 abi reuses the env and argv memory layout of the lp64 abi, so leave the space to fit the lp64 struct layout. Signed-off-by: Guo Ren (Alibaba DAMO Academy) <guoren@kernel.org> --- fs/exec.c | 4 ++++ 1 file changed, 4 insertions(+)diff --git a/fs/exec.c b/fs/exec.c index 506cd411f4ac..548d18b7ae92 100644 --- a/fs/exec.c +++ b/fs/exec.c@@ -424,6 +424,10 @@ static const char __user *get_user_arg_ptr(struct user_arg_ptr argv, int nr) } #endif +#if defined(CONFIG_64BIT) && (BITS_PER_LONG == 32)
okay, #if defined(CONFIG_64BIT) && BITS_PER_LONG == 32
Parens don't seem necessary...quoted
+ nr = nr * 2;Why not nr *= 2?
okay, nr *= 2; -- Best Regards Guo Ren