Re: [PATCH v2 03/11] sched: Add sched tracepoints for RV task model
From: Steven Rostedt <rostedt@goodmis.org>
Date: 2025-02-17 16:39:11
Also in:
lkml, oe-kbuild-all
From: Steven Rostedt <rostedt@goodmis.org>
Date: 2025-02-17 16:39:11
Also in:
lkml, oe-kbuild-all
On Fri, 14 Feb 2025 12:15:31 +0100 Gabriele Monaco [off-list ref] wrote:
quoted
quoted
> 503 __do_trace_sched_set_state_tp(current, current->__state, state_value); 504 } 505 EXPORT_SYMBOL(__do_trace_set_current_state); 506I honestly don't get why this build failed. The function __do_trace_ exists since cff6d93eab00ba ("tracepoint: Reduce duplication of __DO_TRACE_CALL"), a while before that it was just a macro and not an inline function, reason why no one so far used it directly. Both failed builds are based on 4dc1d1bec898 (where my patchset is based) and there __do_trace_ does exist. Unless there's a strong opinion not to use it although the compiler allows it, I'd consider the two kernel robot results false negatives. Or am I missing something?
It's because you should not be using the internal macros of a tracepoint. Just use the tracepoint itself. I replied to the patch. -- Steve