Re: [PATCH v2 04/11] rv: Add option for nested monitors and include sched
From: Gabriele Monaco <gmonaco@redhat.com>
Date: 2025-02-17 06:56:33
Also in:
lkml, oe-kbuild-all
On Mon, 2025-02-17 at 06:39 +0800, kernel test robot wrote:
Hi Gabriele, kernel test robot noticed the following build warnings: [auto build test WARNING on 4dc1d1bec89864d8076e5ab314f86f46442bfb02] url: https://github.com/intel-lab-lkp/linux/commits/Gabriele-Monaco/tracing-Fix-DECLARE_TRACE_CONDITION/20250213-171642 base: 4dc1d1bec89864d8076e5ab314f86f46442bfb02 patch link: https://lore.kernel.org/r/20250213090819.419470-5-gmonaco%40redhat.com patch subject: [PATCH v2 04/11] rv: Add option for nested monitors and include sched config: parisc-randconfig-r112-20250217 (https://download.01.org/0day-ci/archive/20250217/202502170630.xSYE4c Uk-lkp@intel.com/config) compiler: hppa-linux-gcc (GCC) 14.2.0 reproduce: (https://download.01.org/0day-ci/archive/20250217/202502170630.xSYE4c Uk-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tagsquoted
Reported-by: kernel test robot <redacted> Closes: https://lore.kernel.org/oe-kbuild-all/202502170630.xSYE4cUk-lkp@intel.com/ (local)All warnings (new ones prefixed by >>): In file included from include/trace/define_trace.h:119, from kernel/trace/rv/rv_trace.h:130, from kernel/trace/rv/rv.c:148:quoted
quoted
include/trace/trace_events.h:477:13: warning: 'print_fmt_error_da_monitor' defined but not used [-Wunused- variable]477 | static char print_fmt_##call[] = print; \ | ^~~~~~~~~~ kernel/trace/rv/./rv_trace.h:39:1: note: in expansion of macro 'DECLARE_EVENT_CLASS' 39 | DECLARE_EVENT_CLASS(error_da_monitor, | ^~~~~~~~~~~~~~~~~~~quoted
quoted
include/trace/trace_events.h:477:13: warning: 'print_fmt_event_da_monitor' defined but not used [-Wunused- variable]477 | static char print_fmt_##call[] = print; \ | ^~~~~~~~~~ kernel/trace/rv/./rv_trace.h:12:1: note: in expansion of macro 'DECLARE_EVENT_CLASS' 12 | DECLARE_EVENT_CLASS(event_da_monitor, | ^~~~~~~~~~~~~~~~~~~quoted
quoted
include/trace/trace_events.h:223:37: warning: 'trace_event_type_funcs_error_da_monitor' defined but not used [- Wunused-variable]223 | static struct trace_event_functions trace_event_type_funcs_##call = { \ | ^~~~~~~~~~~~~~~~~~~~~~~ kernel/trace/rv/./rv_trace.h:39:1: note: in expansion of macro 'DECLARE_EVENT_CLASS' 39 | DECLARE_EVENT_CLASS(error_da_monitor, | ^~~~~~~~~~~~~~~~~~~quoted
quoted
include/trace/trace_events.h:223:37: warning: 'trace_event_type_funcs_event_da_monitor' defined but not used [- Wunused-variable]223 | static struct trace_event_functions trace_event_type_funcs_##call = { \ | ^~~~~~~~~~~~~~~~~~~~~~~ kernel/trace/rv/./rv_trace.h:12:1: note: in expansion of macro 'DECLARE_EVENT_CLASS' 12 | DECLARE_EVENT_CLASS(event_da_monitor, | ^~~~~~~~~~~~~~~~~~~
This is something hard to trigger, but I didn't remove the select DA_MON_EVENTS_IMPLICIT in RV_MON_SCHED . As a result if the user enables the sched monitor without any nested monitor (which is already a broken configuration but happens if you apply this commit without the following ones) trace event classes would be created with no event using them. I will send a V2 with the fix.