Thread (28 messages) 28 messages, 4 authors, 2024-12-18

Re: [PATCH 1/3] ring-buffer: Add uname to match criteria for persistent ring buffer

From: Steven Rostedt <rostedt@goodmis.org>
Date: 2024-12-18 00:47:47
Also in: lkml, stable

On Tue, 17 Dec 2024 16:02:34 -0800
Linus Torvalds [off-list ref] wrote:
On Tue, 17 Dec 2024 at 15:32, Linus Torvalds
[off-list ref] wrote:
quoted
But if you look more closely, you'll see that the way the buffer is
managed is actually not as a word array at all, but using

        char *str, *end;

instead of word pointers.  
Oh, and in addition to the smaller-than-int types ('%c' and '%hd'
etc), pointers that get dereferenced also get written as a byte string
to that word array. There might be other cases too.

So it's really a fairly odd kind of "sometimes words, sometimes not"
array, with the size of the array given in words.

That binary printf is very strange.
Note that at least on the tracing user space side, as trace_printk() is
never used in production systems and mostly just used for debugging, we can
be pretty liberal if I have to change libtraceevent.

I could even add an update to the format file to have the library stay
backward compatible with older kernels and can see that the format file has
been updated to know that the vbin_printf() has changed.

-- Steve
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help