Thread (28 messages) 28 messages, 4 authors, 2024-12-18

Re: [PATCH 1/3] ring-buffer: Add uname to match criteria for persistent ring buffer

From: Steven Rostedt <rostedt@goodmis.org>
Date: 2024-12-17 19:13:43
Also in: lkml, stable

On Tue, 17 Dec 2024 14:07:50 -0500
Steven Rostedt [off-list ref] wrote:
On Tue, 17 Dec 2024 11:03:28 -0800
Linus Torvalds [off-list ref] wrote:
quoted
On Tue, 17 Dec 2024 at 10:42, Linus Torvalds
[off-list ref] wrote:  
quoted
My initial suggestion was to just fix up the boot time array.

I think that's actually wrong. Just print the raw data and analyze it
in user space.    
.. I still think it's not the optimal solution, but fixing up the
event data from the previous boot (*before* printing it, and entirely
independently of vsnprintf()) would at least avoid the whole "mess
with vsnprintf and switch the format string around as you are trying
to walk the va_list in sync".
And that code that does the va_list and vsnprintf() tricks is going to be
removed as soon as that patch set finishes going through my full test suite,
and you are OK with the solution.

Again, that patch set is here:

  https://lore.kernel.org/linux-trace-kernel/20241217024118.587584221@goodmis.org/ (local)

-- Steve
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help