Thread (16 messages) 16 messages, 5 authors, 2024-10-21

RE: [PATCH v6 2/5] tracing: Add __print_dynamic_array() helper

From: "Zhuo, Qiuxu" <qiuxu.zhuo@intel.com>
Date: 2024-10-17 06:58:35
Also in: linux-edac, lkml

quoted hunk ↗ jump to hunk
From: Avadhut Naik <avadhut.naik@amd.com>
[...]
diff --git a/include/trace/stages/stage3_trace_output.h
b/include/trace/stages/stage3_trace_output.h
index c1fb1355d309..8e3215093e1f 100644
--- a/include/trace/stages/stage3_trace_output.h
+++ b/include/trace/stages/stage3_trace_output.h
@@ -119,6 +119,14 @@
 		trace_print_array_seq(p, array, count, el_size);	\
 	})

+#undef __print_dynamic_array
+#define __print_dynamic_array(array, el_size)				\
+	({								\
+		__print_array(__get_dynamic_array(array),		\
+			      __get_dynamic_array_len(array) / el_size,	\
+			      el_size);					\
+	})
+
When running the check below: 

    ${LINUX}/scripts/checkpatch.pl --strict  <this patch> 

it complains:

    CHECK: Macro argument 'el_size' may be better as '(el_size)' to avoid precedence issues
    #36: FILE: include/trace/stages/stage3_trace_output.h:123:
    +#define __print_dynamic_array(array, el_size)                          \
    +       ({                                                              \
    +               __print_array(__get_dynamic_array(array),               \
    +                             __get_dynamic_array_len(array) / el_size, \
    +                             el_size);                                 \
    +       })

-Qiuxu
[...]
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help