Re: tools/rtla: Fix installation from out-of-tree build
From: Ben Hutchings <hidden>
Date: 2024-10-13 21:02:48
Attachments
- signature.asc [application/pgp-signature] 833 bytes
From: Ben Hutchings <hidden>
Date: 2024-10-13 21:02:48
On Thu, 2024-10-10 at 13:39 -0400, John Kacur wrote:
On Mon, 16 Sep 2024, Ben Hutchings wrote:quoted
rtla now supports out-of-tree builds, but installation fails as it still tries to install the rtla binary from the source tree. Use the existing macro $(RTLA) to refer to the binary. Fixes: 01474dc706ca ("tools/rtla: Use tools/build makefiles to build rtla") Signed-off-by: Ben Hutchings <redacted> ------ a/tools/tracing/rtla/Makefile.rtla +++ b/tools/tracing/rtla/Makefile.rtla@@ -38,7 +38,7 @@ BINDIR := /usr/bin .PHONY: install install: doc_install @$(MKDIR) -p $(DESTDIR)$(BINDIR) - $(call QUIET_INSTALL,rtla)$(INSTALL) rtla -m 755 $(DESTDIR)$(BINDIR) + $(call QUIET_INSTALL,rtla)$(INSTALL) $(RTLA) -m 755 $(DESTDIR)$(BINDIR) @$(STRIP) $(DESTDIR)$(BINDIR)/rtla @test ! -f $(DESTDIR)$(BINDIR)/osnoise || $(RM) $(DESTDIR)$(BINDIR)/osnoise @$(LN) rtla $(DESTDIR)$(BINDIR)/osnoiseIs Debian using out of tree builds Ben?
[...] In the linux package specifically, yes, we try to do all builds out-of- tree. Ben. -- Ben Hutchings - Debian developer, member of kernel, installer and LTS teams