Re: tools/rtla: Fix installation from out-of-tree build
From: John Kacur <jkacur@redhat.com>
Date: 2024-10-10 17:39:18
On Mon, 16 Sep 2024, Ben Hutchings wrote:
quoted hunk ↗ jump to hunk
rtla now supports out-of-tree builds, but installation fails as it still tries to install the rtla binary from the source tree. Use the existing macro $(RTLA) to refer to the binary. Fixes: 01474dc706ca ("tools/rtla: Use tools/build makefiles to build rtla") Signed-off-by: Ben Hutchings <redacted> ------ a/tools/tracing/rtla/Makefile.rtla +++ b/tools/tracing/rtla/Makefile.rtla@@ -38,7 +38,7 @@ BINDIR := /usr/bin .PHONY: install install: doc_install @$(MKDIR) -p $(DESTDIR)$(BINDIR) - $(call QUIET_INSTALL,rtla)$(INSTALL) rtla -m 755 $(DESTDIR)$(BINDIR) + $(call QUIET_INSTALL,rtla)$(INSTALL) $(RTLA) -m 755 $(DESTDIR)$(BINDIR) @$(STRIP) $(DESTDIR)$(BINDIR)/rtla @test ! -f $(DESTDIR)$(BINDIR)/osnoise || $(RM) $(DESTDIR)$(BINDIR)/osnoise @$(LN) rtla $(DESTDIR)$(BINDIR)/osnoise
Is Debian using out of tree builds Ben? This is upstream already which is fine, but I remember Daniel telling me that he believed the distributions were no longer using out of tree builds and he wanted to remove this capability in order to simplify the build system. John Kacur