Re: [PATCH 2/6] tracing: Replace memcpy() with __get_task_comm()

[PATCH 0/6] kernel: Avoid memcpy of task comm · Yafang Shao <hidden> · 2024-06-02
[PATCH 1/6] fs/exec: Drop task_lock() inside __get_task_comm() · Yafang Shao <hidden> · 2024-06-02
Re: [PATCH 1/6] fs/exec: Drop task_lock() inside __get_task_comm() · Matus Jokay <hidden> · 2024-06-04
Re: [PATCH 1/6] fs/exec: Drop task_lock() inside __get_task_comm() · Matus Jokay <hidden> · 2024-06-04
Re: [PATCH 1/6] fs/exec: Drop task_lock() inside __get_task_comm() · Yafang Shao <hidden> · 2024-06-05
[PATCH 2/6] tracing: Replace memcpy() with __get_task_comm() · Yafang Shao <hidden> · 2024-06-02
Re: [PATCH 2/6] tracing: Replace memcpy() with __get_task_comm() · Steven Rostedt <rostedt@goodmis.org> · 2024-06-03
Re: [PATCH 2/6] tracing: Replace memcpy() with __get_task_comm() · Linus Torvalds <torvalds@linux-foundation.org> · 2024-06-03
Re: [PATCH 2/6] tracing: Replace memcpy() with __get_task_comm() · Steven Rostedt <rostedt@goodmis.org> · 2024-06-03
Re: [PATCH 2/6] tracing: Replace memcpy() with __get_task_comm() · Linus Torvalds <torvalds@linux-foundation.org> · 2024-06-03
Re: [PATCH 2/6] tracing: Replace memcpy() with __get_task_comm() · Steven Rostedt <rostedt@goodmis.org> · 2024-06-03
Re: [PATCH 2/6] tracing: Replace memcpy() with __get_task_comm() · Linus Torvalds <torvalds@linux-foundation.org> · 2024-06-03
Re: [PATCH 2/6] tracing: Replace memcpy() with __get_task_comm() · Steven Rostedt <rostedt@goodmis.org> · 2024-06-03
Re: [PATCH 2/6] tracing: Replace memcpy() with __get_task_comm() · Yafang Shao <hidden> · 2024-06-04
[PATCH 3/6] auditsc: Replace memcpy() with __get_task_comm() · Yafang Shao <hidden> · 2024-06-02
Re: [PATCH 3/6] auditsc: Replace memcpy() with __get_task_comm() · Paul Moore <paul@paul-moore.com> · 2024-06-03
[PATCH 4/6] security: Replace memcpy() with __get_task_comm() · Yafang Shao <hidden> · 2024-06-02
Re: [PATCH 4/6] security: Replace memcpy() with __get_task_comm() · Paul Moore <paul@paul-moore.com> · 2024-06-03
[PATCH 5/6] bpftool: Make task comm always be NUL-terminated · Yafang Shao <hidden> · 2024-06-02
Re: [PATCH 5/6] bpftool: Make task comm always be NUL-terminated · Quentin Monnet <qmo@kernel.org> · 2024-06-02
[PATCH 6/6] selftests/bpf: Replace memcpy() with __get_task_comm() · Yafang Shao <hidden> · 2024-06-02

From: Linus Torvalds <torvalds@linux-foundation.org>
Date: 2024-06-03 22:24:08
Also in: bpf, linux-fsdevel, linux-mm, linux-security-module, selinux

On Mon, 3 Jun 2024 at 15:18, Steven Rostedt [off-list ref] wrote:

The logic behind __string() and __assign_str() will always add a NUL
character.

Ok. But then you still end up with the issue that now the profiles are
different, and you have a 8-byte pointer to dynamically allocated
memory instead of just the simpler comm[TASK_COMM_LEN].

Is that actually a good idea for tracing?

We're trying to fix the core code to be cleaner for places that may
actually *care* (like 'ps').

Would we really want to touch this part of tracing?

            Linus

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help