Thread (21 messages) 21 messages, 6 authors, 2024-06-05

Re: [PATCH 2/6] tracing: Replace memcpy() with __get_task_comm()

From: Linus Torvalds <torvalds@linux-foundation.org>
Date: 2024-06-03 21:42:30
Also in: bpf, linux-fsdevel, linux-mm, linux-security-module, selinux

On Mon, 3 Jun 2024 at 14:19, Steven Rostedt [off-list ref] wrote:
-               __array(        char,   comm,   TASK_COMM_LEN   )
+               __string(       comm,   strlen(comm)            )
Is this actually safe is 'comm[]' is being modified at the same time?
The 'strlen()' will not be consistent with the string copy.

Because that is very much the case. It's not a stable source.

For example, strlen() may return 5. But by the time  you then actually
copy the data, the string may have changed, and there would not
necessarily be a NUL character at comm[5] any more. It might be
further in the string, or it might be earlier.

                  Linus
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help