Re: [RFC PATCH 24/32] x86/ftrace: Enable HAVE_FUNCTION_GRAPH_FREGS
From: Peter Zijlstra <peterz@infradead.org>
Date: 2023-11-06 10:20:06
Also in:
bpf, lkml
Subsystem:
function hooks (ftrace), the rest, x86 architecture (32-bit and 64-bit) · Maintainers:
Steven Rostedt, Masami Hiramatsu, Linus Torvalds, Thomas Gleixner, Ingo Molnar, Borislav Petkov, Dave Hansen
On Mon, Nov 06, 2023 at 09:38:50AM +0900, Masami Hiramatsu wrote:
On Sun, 5 Nov 2023 18:34:09 -0500 Steven Rostedt [off-list ref] wrote:quoted
On Sun, 5 Nov 2023 18:33:01 -0500 Steven Rostedt [off-list ref] wrote:quoted
For x86_64, that would be: rdi, rsi, rdx, r8, r9, rspI missed rcx.I would like to add rax to the list so that it can handle the return value too. :)
So something like so?
diff --git a/arch/x86/include/asm/ftrace.h b/arch/x86/include/asm/ftrace.h
index 897cf02c20b1..71bfe27594a5 100644
--- a/arch/x86/include/asm/ftrace.h
+++ b/arch/x86/include/asm/ftrace.h@@ -36,6 +36,10 @@ static inline unsigned long ftrace_call_adjust(unsigned long addr) #ifdef CONFIG_HAVE_DYNAMIC_FTRACE_WITH_ARGS struct ftrace_regs { + /* + * Partial, filled with: + * rax, rcx, rdx, rdi, rsi, r8, r9, rsp + */ struct pt_regs regs; };