Re: [RFC PATCH v2 06/20] tracing/filters: Optimise scalar vs cpumask filtering when the user mask is a single CPU

On Mon, 31 Jul 2023 19:03:04 +0300
Dan Carpenter [off-list ref] wrote:

quoted

quoted

quoted

Nit, the above can be written as:

			pred->op = pret->op != OP_BAND ? : OP_EQ;
    

Heh.  Those are not equivalent.  The right way to write this is:  

You mean because of my typo?  

No, I hadn't seen the s/pred/pret/ typo.  Your code does:

	if (pred->op != OP_BAND)
		pred->op = true;
	else
		pred->op OP_EQ;

Ah, for some reason I was thinking the ? : just was just a nop, but I guess
it is to assign the cond value :-/

But of course every place I've done that, it was the condition value I
wanted, which was the same as the value being assigned.

Thanks,

-- Steve