Thread (7 messages) flat view 7 messages, 3 authors, 2023-03-20

Re: [PATCH] trace/events/sched: Remove unit on printing vruntime value

From: Peter Zijlstra <peterz@infradead.org>
Date: 2023-03-20 11:42:05

On Sun, Mar 19, 2023 at 02:07:38PM -0400, Steven Rostedt wrote:
On Sun, 19 Mar 2023 12:05:20 +0900
Gildong Hong [off-list ref] wrote:
quoted
quoted
quoted
-	TP_printk("comm=%s pid=%d runtime=%Lu [ns] vruntime=%Lu [ns]",
+	TP_printk("comm=%s pid=%d runtime=%Lu [ns] vruntime=%Lu",  
quoted
"vns" sounds nice.
But some people may hard to understand the meaning.
"ns" is a global standard time unit where "vns" is not.
So I still prefer to remove the unit.
Really? You have "runtime" (which most people understand) and labeled
"ns", but then you have "vruntime" which some people may find hard to
understand the meaning of. If they do understand the meaning of
"vruntime" then they should have the means to understand "vns".

Otherwise, no label is meaningless too!
I'm with Steve, if you're down to consuming these here numbers, you'd
better know wth you're doing.

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help