From: Gildong Hong <hidden> Date: 2023-03-16 11:57:42
vruntime is not actual time so remove unit on printing
Signed-off-by: Gildong Hong <redacted>
---
include/trace/events/sched.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
From: Steven Rostedt <rostedt@goodmis.org> Date: 2023-03-16 14:12:05
On Thu, 16 Mar 2023 20:56:55 +0900
Gildong Hong [off-list ref] wrote:
quoted hunk
vruntime is not actual time so remove unit on printing
Signed-off-by: Gildong Hong <redacted>
---
include/trace/events/sched.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
From: Gildong Hong <hidden> Date: 2023-03-19 03:05:32
On Thu, Mar 16, 2023 at 10:11:37AM -0400, Steven Rostedt wrote:
On Thu, 16 Mar 2023 20:56:55 +0900
Gildong Hong [off-list ref] wrote:
quoted
vruntime is not actual time so remove unit on printing
Signed-off-by: Gildong Hong <redacted>
---
include/trace/events/sched.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
What about calling it "[vns]" for "virtual nanosecond" ?
;-)
-- Steve
quoted
__entry->comm, __entry->pid,
(unsigned long long)__entry->runtime,
(unsigned long long)__entry->vruntime)
Dear Steve
"vns" sounds nice.
But some people may hard to understand the meaning.
"ns" is a global standard time unit where "vns" is not.
So I still prefer to remove the unit.
Thanks for your review.
Gildong
"vns" sounds nice.
But some people may hard to understand the meaning.
"ns" is a global standard time unit where "vns" is not.
So I still prefer to remove the unit.
Really? You have "runtime" (which most people understand) and labeled
"ns", but then you have "vruntime" which some people may find hard to
understand the meaning of. If they do understand the meaning of
"vruntime" then they should have the means to understand "vns".
Otherwise, no label is meaningless too!
-- Steve
"vns" sounds nice.
But some people may hard to understand the meaning.
"ns" is a global standard time unit where "vns" is not.
So I still prefer to remove the unit.
Really? You have "runtime" (which most people understand) and labeled
"ns", but then you have "vruntime" which some people may find hard to
understand the meaning of. If they do understand the meaning of
"vruntime" then they should have the means to understand "vns".
Otherwise, no label is meaningless too!
-- Steve
I agree with your opinion.
People can understand "vns" if they understand "vruntime".
Followings are the modified patch.
I add your name on "Suggested-by"
I or you could remove the line if you mind it.
Thanks,
Gildong
------------
From 8a8d1f08a2f217151f26f04795d6c1483eb1c48f Mon Sep 17 00:00:00 2001
From: Gildong Hong <redacted>
Date: Thu, 16 Mar 2023 20:05:48 +0900
Subject: [PATCH] trace/events/sched: Change unit on printing vruntime value
vruntime is not actual time so change unit on printing
from "ns" to "vns" which denotes "virtual nanosecond"
Suggested-by: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: Gildong Hong <redacted>
---
include/trace/events/sched.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
"vns" sounds nice.
But some people may hard to understand the meaning.
"ns" is a global standard time unit where "vns" is not.
So I still prefer to remove the unit.
Really? You have "runtime" (which most people understand) and labeled
"ns", but then you have "vruntime" which some people may find hard to
understand the meaning of. If they do understand the meaning of
"vruntime" then they should have the means to understand "vns".
Otherwise, no label is meaningless too!
I'm with Steve, if you're down to consuming these here numbers, you'd
better know wth you're doing.
From: Steven Rostedt <rostedt@goodmis.org> Date: 2023-03-20 18:10:33
On Mon, 20 Mar 2023 20:41:39 +0900
Gildong Hong [off-list ref] wrote:
I agree with your opinion.
People can understand "vns" if they understand "vruntime".
Followings are the modified patch.
I add your name on "Suggested-by"
I or you could remove the line if you mind it.
I'm good.
Thanks,
-- Steve
Thanks,
Gildong
------------
quoted
From 8a8d1f08a2f217151f26f04795d6c1483eb1c48f Mon Sep 17 00:00:00 2001
From: Gildong Hong <redacted>
Date: Thu, 16 Mar 2023 20:05:48 +0900
Subject: [PATCH] trace/events/sched: Change unit on printing vruntime value
vruntime is not actual time so change unit on printing
from "ns" to "vns" which denotes "virtual nanosecond"
Suggested-by: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: Gildong Hong <redacted>