Re: [PATCH rdma-next 03/13] RDMA: Split kernel-only create QP flags from uverbs create QP flags
From: Jason Gunthorpe <jgg@nvidia.com>
Date: 2023-01-17 13:50:10
Also in:
linux-nvme, linux-rdma, lkml, netdev
On Tue, Jan 17, 2023 at 02:03:07PM +0200, Leon Romanovsky wrote:
On Mon, Jan 16, 2023 at 01:39:38PM -0400, Jason Gunthorpe wrote:quoted
On Mon, Jan 16, 2023 at 03:05:50PM +0200, Leon Romanovsky wrote:quoted
diff --git a/drivers/infiniband/hw/mlx4/mlx4_ib.h b/drivers/infiniband/hw/mlx4/mlx4_ib.h index 17fee1e73a45..c553bf0eb257 100644 --- a/drivers/infiniband/hw/mlx4/mlx4_ib.h +++ b/drivers/infiniband/hw/mlx4/mlx4_ib.h@@ -184,7 +184,7 @@ enum mlx4_ib_qp_flags { /* Mellanox specific flags start from IB_QP_CREATE_RESERVED_START */ MLX4_IB_ROCE_V2_GSI_QP = MLX4_IB_QP_CREATE_ROCE_V2_GSI, MLX4_IB_SRIOV_TUNNEL_QP = 1 << 30, - MLX4_IB_SRIOV_SQP = 1 << 31, + MLX4_IB_SRIOV_SQP = 1ULL << 31, };These should be moved to a uapi if we are saying they are userspace available But I'm not sure they are?I don't think so.
Then they should be > 32 bits right? Jason