15.12.2021 16:14, Thierry Reding пишет:

On Sun, Dec 12, 2021 at 12:13:59AM +0300, Dmitry Osipenko wrote:

quoted

From: Stefan Eichenberger <redacted>

If an USB port is an OTG port, then we should add the usb-role-switch
property. Otherwise XUSB setup fails and therefore padctl is unable to
set up the ports. This leads to broken USB and PCIe ports. Add the
usb-role-switch properties to Tegra124 device-trees to fix the problem.

The error message shown without this patch is e.g:
usb2-0: usb-role-switch not found for otg mode

[digetx@gmail.com: improved commit message]
Tested-by: Thomas Graichen <redacted> # T124 Nyan Big
Signed-off-by: Stefan Eichenberger <redacted>
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 arch/arm/boot/dts/tegra124-apalis-v1.2.dtsi | 1 +
 arch/arm/boot/dts/tegra124-apalis.dtsi      | 1 +
 arch/arm/boot/dts/tegra124-nyan.dtsi        | 1 +
 arch/arm/boot/dts/tegra124-venice2.dts      | 2 +-
 4 files changed, 4 insertions(+), 1 deletion(-)

The device tree bindings for the XUSB pad controller say that when this
property is set, then the "connector" subnode should also exist.

Any chance we can add that? I was planning on making that a dependency
in the json-schema conversion of the binding, in which case it would be
more of a "must" than a "should".

I guess it will be harmless if you'll add the connector subnodes. Will
you be able to create a separate patch that will add the subnodes on top
of this patch?

Thomas Graichen says that one USB port on Nyan Big doesn't work without
this patch. This is why this patch is needed essentially.