Re: staging: r8188eu: Can odm_DynamicTxPowerNIC() be removed?
From: Dan Carpenter <hidden>
Date: 2021-09-20 08:34:18
Also in:
lkml
From: Dan Carpenter <hidden>
Date: 2021-09-20 08:34:18
Also in:
lkml
On Sat, Sep 18, 2021 at 03:31:48PM +0200, Michael Straube wrote:
Hi Larry, Phillip and all.
While removing code that checks for the chip type I stumbled upon this:
void odm_DynamicTxPowerNIC(struct odm_dm_struct *pDM_Odm)
{
if (!(pDM_Odm->SupportAbility & ODM_BB_DYNAMIC_TXPWR))
return;
if (pDM_Odm->SupportICType == ODM_RTL8188E) {
/* ??? */
/* This part need to be redefined. */
}
}Always just delete dead code. The future is very hard to predict so don't leave things lying around because of possible futures. Don't be a hoarder. regards, dan carpenter