Thread (4 messages) 4 messages, 3 authors, 2021-09-20

staging: r8188eu: Can odm_DynamicTxPowerNIC() be removed?

From: Michael Straube <hidden>
Date: 2021-09-18 13:31:57
Also in: lkml

Hi Larry, Phillip and all.

While removing code that checks for the chip type I stumbled upon this:


void odm_DynamicTxPowerNIC(struct odm_dm_struct *pDM_Odm)
{
	if (!(pDM_Odm->SupportAbility & ODM_BB_DYNAMIC_TXPWR))
		return;

	if (pDM_Odm->SupportICType == ODM_RTL8188E) {
		/*  ??? */
		/*  This part need to be redefined. */
	}
}


(pDM_Odm->SupportICType == ODM_RTL8188E) is always true in this driver.
Currently the function does nothing and the driver seems to work fine.
Because of the comment I'm not sure if the whole function can just be
removed?

Regards,
Michael
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help