Re: [PATCH] staging: r8188eu: core: remove condition with no effect
From: SAURAV GIREPUNJE <hidden>
Date: 2021-08-28 12:24:21
Also in:
lkml
From: SAURAV GIREPUNJE <hidden>
Date: 2021-08-28 12:24:21
Also in:
lkml
On 26 Aug 2021 12:34, Greg KH wrote:
On Sun, Aug 22, 2021 at 02:36:11PM +0200, Greg KH wrote:quoted
On Sun, Aug 22, 2021 at 01:06:09PM +0200, Fabio M. De Francesco wrote:quoted
On Sunday, August 22, 2021 1:58:10 AM CEST Phillip Potter wrote:quoted
On Sat, 21 Aug 2021 at 21:23, Saurav Girepunje [off-list ref] wrote:quoted
Remove the condition with no effect (if == else) in rtw_led.c file. Signed-off-by: Saurav Girepunje <redacted> --- drivers/staging/r8188eu/core/rtw_led.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)Thanks for this, looks good. Acked-by: Phillip Potter <phil@philpotter.co.uk> Regards, PhilDear Philip, Before acking, please check at least if it applies to the current version of the tree and check if it compiles without adding warnings and / or errors. :-)That is not necessary or needed here, I can do that when I apply the patch.As proof of that, this patch applied just fine to my tree right now... thanks, greg k-h
Thanks greg