Re: [PATCH] staging: r8188eu: core: remove condition with no effect
From: Phillip Potter <phil@philpotter.co.uk>
Date: 2021-08-22 23:58:45
Also in:
lkml
From: Phillip Potter <phil@philpotter.co.uk>
Date: 2021-08-22 23:58:45
Also in:
lkml
On Sun, 22 Aug 2021 at 17:24, Fabio M. De Francesco [off-list ref] wrote:
Dear Philip, I didn't mean to be harsh with you, I apologize if this is the message I conveyed. Really!
Dear Fabio, No apology necessary :-)
Now it is clearer to me what acking means. I've given only a handful of acks because I thought I should also check if they applied and if they build. It takes time. Now I understand it is not required. Thanks.
Yeah I try to ack as many as I can now, but couldn't possibly do as many as I do if I had to build test them all, especially with my own code to write and a family/full time non-kernel dev role. It is certainly desirable for the majority, but if the code looks good/correct and is a simple patch then in my mind an Acked-by is fine to give in any case. That said, I will no doubt make mistakes on that.
Please, don't ever think I'm not more than sure that you give a lot of your _unpaid_ time to the kernel and I thank you very much I know what it means, because I too have other commitments :-)
Thank you, and I appreciate your involvement so keep up the good work :-) Regards, Phil