Re: [PATCH 5/5] spi: fix return value check in hspi_probe().
From: Dan Carpenter <hidden>
Date: 2012-12-19 16:39:48
Also in:
kernel-janitors, lkml
On Wed, Dec 19, 2012 at 03:11:54PM +0000, Grant Likely wrote:
On Tue, 11 Dec 2012 16:36:27 -0800 (PST), Kuninori Morimoto [off-list ref] wrote:quoted
Hiquoted
According to its documentation, clk_get() returns a "valid IS_ERR() condition containing errno", so we should call IS_ERR() rather than a NULL check. Signed-off-by: Cyril Roelandt <redacted>Acked-by: Kuninori Morimoto <redacted>Applied, thanks.
In another thread, we were just talking about who clk_get() can return a NULL if !CONFIG_HAVE_CLK. That might change to match the documentation later... Not sure. regards, dan carpenter ------------------------------------------------------------------------------ LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial Remotely access PCs and mobile devices and provide instant support Improve your efficiency, and focus on delivering more value-add services Discover what IT Professionals Know. Rescue delivers http://p.sf.net/sfu/logmein_12329d2d